[LTP] [PATCH v3 2/2] testcases/clock_nanosleep01: convert to use new test library API

Cyril Hrubis chrubis@suse.cz
Mon Nov 28 10:32:36 CET 2016

> > Otherwise this version looks very good. Just keep in mind to keep the
> > lines under 80 characters.
> Right! I'm sorry about being relaxed on this so far.
> Just a question about strings: kernel formatting style [1] says about it:
> > However, never break user-visible strings such as
> > printk messages, because that breaks the ability to grep for them.
> And indeed my using plugin forcing kernel coding style [2] doesn't complain on strings
> So I hope string long up to 90 characters are still ok.

As far as I can tell we do not have any hard rules about this in LTP,
some code splits up the strings, some does not. I personally am trying
to keep things as short as possible while including all important bits
and I'm also avoiding unnecessary levels of indentation which keeps
things under 80 chars most of the time. I tend to split the string if
the line goes too long, which seems to be more or less about 130 chars.

Cyril Hrubis

More information about the ltp mailing list