[LTP] new shell library

Cyril Hrubis chrubis@suse.cz
Tue Oct 4 13:50:15 CEST 2016


Hi!
> > I somehow find it more clear to define all the variables that the
> > library script uses before we source it. IMHO that is better than having
> > them scattered all around the script, at this point both the old test.sh
> > and tst_test.sh scripts enforce that by doing sanity checks on the
> > variables when the library script is sourced.
> > 
> > Are any advantages for doing the sanity checks in the tst_run function?
> 
> Can't think of any. You (and old test.sh) convinced me to go with your
> example. Let's give it couple days, if anyone else wants to weigh in.

FYI I've changed the code at [1] accordingly to our discussion as it was
easy enough, mostly just shuffling code around.

[1] https://github.com/metan-ucw/ltp/commits/master

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list