[LTP] [PATCH 2/2] writev: remove old tests for partially invalid iovec

Cyril Hrubis chrubis@suse.cz
Wed Oct 5 17:38:56 CEST 2016


Hi!
> -	/* testcase# 3 */
> +	/* TODO: remove this, partially invalid iovec is tested in writev07 */
>  	{(buf1 + CHUNK * 6), CHUNK},
>  	{(caddr_t) - 1, CHUNK},
>  	{(buf1 + CHUNK * 8), CHUNK},

Maybe it would be better to split this into five struct iovec structures
to avoid the magic constants in the code. Otherwise it's fine.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list