[LTP] new shell library

Cyril Hrubis chrubis@suse.cz
Wed Oct 12 14:36:02 CEST 2016


Hi!
> > I've started to document the new shell library (the changes to
> > test-writing-guidelines are now included in [1]) and also tried to think
> > of some library hardening, i.e. making sure to avoid common mistakes,
> > the only thing I came up with is [2]. What do you think about this
> > approach?
> 
> I don't have better idea than some checks on inclusion of test.sh or in tst_run.
> 
> As for things we can check, I was thinking matching "set | grep ^TST_"
> against list of all supported variables. A typo or non-existing/deprecated
> variable would immediately show up.

What about greping the test source as in [2] instead? Because that way
we can print error if the test source touches any of the internally used
variables as well. For instance if it tries to do anything with
TST_PASS/TST_FAIL/...

> > [2]
> > https://github.com/metan-ucw/ltp/commit/7ca6be805c9fa4083b7e4de7f28162fca6a4a090

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list