[LTP] [PATCH] pan/ltp-pan.c: fix incorrect number of total tests

[Xiao Yang]

On 2017/04/10 21:50, Cyril Hrubis wrote:
> Hi!
>>   pan/ltp-pan.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
>> index 1614c70..beed623 100644
>> --- a/pan/ltp-pan.c
>> +++ b/pan/ltp-pan.c
>> @@ -645,7 +645,7 @@ int main(int argc, char **argv)
>>   				strerror(errno));
>>   		fprintf(logfile,
>>   			"\n-----------------------------------------------\n");
>> -		fprintf(logfile, "Total Tests: %d\n", coll->cnt);
>> +		fprintf(logfile, "Total Tests: %d\n", (coll->cnt - starts));
> This change does not make much sense to me. The coll->cnt is number of
> tests loaded from the runtest file, right? The starts is basically
> number of tests to be executed. The runltp script executes ltp-pan with
> -S which means that starts is set to coll->cnt in the main() function
> and so after this change it would print "Total Tests: 0" regardless.
>
Hi Cyril

Actually, the coll->cnt is number of tests loaded from the runtest file.
However, starts is set to coll->cnt at first , and it reduces when 
completing one test.
Please see the following code:
cpid =
run_child(coll->ary[c], running + i, quiet_mode,
&failcnt, fmt_print, logfile);
if (cpid != -1)
++num_active;
if ((cpid != -1 || sequential) && starts > 0)
--starts;

I think that ltp-pan could indicate the number of tests which have been 
run when receiving one signal.
I am not familiar with ltp-pan code，so do you have some suggestions 
about it?

Thanks,
Xiao Yang.