[LTP] [PATCH v3] syscalls: add new test for copy_file_range(2)

Li Wang liwang@redhat.com
Wed Apr 26 09:26:31 CEST 2017


On Wed, Apr 26, 2017 at 3:05 PM, Jan Stancek <jstancek@redhat.com> wrote:
>
>
> ----- Original Message -----
>> On Mon, Apr 24, 2017 at 02:23:41PM +0200, Jan Stancek wrote:
>> > On 04/24/2017 12:46 PM, Li Wang wrote:
>> > >>> These variables names are a bit confusing. But larger problem is
>> > >
>> > > Currently have no idea to improve the confusing issue.
>> > >
>> >
>> > I'm attaching copy_file_range01.c, that I made from your v3 version.
>> > It doesn't use static list of parameters, but instead iterates
>> > over possible values for len/off_in/off_out in all possible combinations.
>> >
>> > Let me know what you think about this approach.
>>
>> To split data structure into arrays is more clear than before, and involve
>> the different function make things simple too. I agree to use this approach.
>
> OK, can this wait after release?

Yes, It's OK to me.



-- 
Regards,
Li Wang
Email: liwang@redhat.com


More information about the ltp mailing list