[LTP] [RFC PATCH v8 08/11] network/stress: Fix and cleanup route IPv4 tests

Petr Vorel pvorel@suse.cz
Wed Aug 23 15:57:48 CEST 2017


Hi Alexey,


> > > +	if [ "$cmd_type" = 'ifconfig_cmd' ]; then
> > > +		cmd="$cmd_name $(tst_iface) down"
> > > +		cmd2="$cmd_name $(tst_iface) up"
> > > +	else
> > > +		cmd="$cmd_name link set down dev $(tst_iface)"
> > > +		cmd2="$cmd_name link set up dev $(tst_iface)"

> > This test-case looks like duplicate of if-updown
> OK, I'll delete testcases/network/stress/route/route4-ifdown and
> testcases/network/stress/route/route6-ifdown. testcases/network/stress/interface/if-updown
> looks cleaner anyway.
Again, I didn't implement adding route before putting the interface down. This delete
route, so the use case is different from if-updown. I fix it and keep the test.

> Anything else to delete? The more time I spend with route tests the more I doubt about
> it's real value.

Kind regards,
Petr


More information about the ltp mailing list