[LTP] [PATCH v2 2/2] syscalls/mbind: cleanup and rewrite mbind01 into new API

[Jan Stancek]

----- Original Message -----
> Hi Jan,
> 
> thanks for your review.
> 
> > I suggest changes below on top of your v2:
> > - drop HAVE_LINUX_MEMPOLICY_H, as it's not used by test
> > - replace no_check_nodemask with "expected nodemask",
> 
> > - drop zero-ing of "nodemask" for MPOL_DEFAULT case, it's not needed
> > anymore
> I'm ok with all but this one. It's needed for a first case
> (POLICY_DESC(MPOL_DEFAULT),),
> no mater whether it's first or not. So I didn't put expected_nodemask to it
> in my v3. Or
> am I'm missing something.

It's not needed, because we compare against "empty_nodemask"
in this case. "nodemask" is not used at all. mbind() doesn't use
any mask (in test_none()) and numa_bitmask_equal() compares
"getnodemask" with "empty_nodemask".

Regards,
Jan

> 
> > - add "static" to global variables/functions
> > - print masks if comparison fails (tst_res_hexd)
> > - collapse no numa and numa == v1 into single main() function
> 
> 
> > No need to re-post if you are OK with the changes.
> I understand this as you've already prepared your changes. In that case push
> it. Otherwise
> I've got v3 which I can post.
> 
> 
> Kind regards,
> Petr
>