[LTP] [RFC PATCH 2/2] lib/test_net.sh: Check for ip command

Alexey Kodanev alexey.kodanev@oracle.com
Thu Dec 7 12:52:52 CET 2017


On 12/06/2017 05:42 PM, Petr Vorel wrote:
> + remove this check from tests which uses test_net.sh.

Not all library functions require 'ip' so why do we need these
rules to apply globally or am I missing something?

>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> I guess most of the time we need root in test_net.sh, but there might be
> someone setting netns with LTP_NETNS and then running tests without root.  Do
> we want to care or we just force tst_require_root in test_net.sh ?

I think we could add it in init_ltp_netspace or/and to tst_restore_ipaddr(),
i.e. checks forip command and root.

Thanks,
Alexey



More information about the ltp mailing list