[LTP] [PATCH v3 09/12] syscalls/mount03: Copy setuid_test to execute instead of 'TEST FILE'

Punit Agrawal punit.agrawal@arm.com
Fri Dec 8 12:50:38 CET 2017


Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> Apologies for not being more specific. We do it twice because in the
>> quoted text you say (emphasis mine) -
>> 
>> "it should be done _once_ in the test setup _as well as_ the code that
>> sets the actual setuid bit."
>>
>> I took that to mean that you're asking for the file to be copied in
>> setup() as well as in the code before it gets used. Obviously I've
>> misunderstood your statement. What are you actually suggesting there?
>
> Ah, that's where the misunderstanding happened, "the code that sets the
> actual setuid bit" == chmod(file, SUID_MODE);
>
> I was trying to state that the actual test setup that could be done only
> once should be put into the test setup.

Right that makes sense.

I'll send an update on this and the getdtablesize patch shortly.


More information about the ltp mailing list