[LTP] [PATCH] runltp: skipfile: skipped test cases should be visible as TCONF in results

[Naresh Kamboju]

Cyril,

On 19 December 2017 at 18:29, Cyril Hrubis <chrubis@suse.cz> wrote:
> Hi!
>> +    if [ -n "${SKIPFILE}" ]; then
>> +        while read -r test_line; do
>> +            case "${test_line}" in \#*) continue ;; esac
>> +            if [ -n "${test_line}" ]; then
>> +                # test_name is first column of each line in SKIPFILE
>> +                test_name=$(echo ${test_line} | awk '{print $1}')
>> +                sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
>> +            fi
>> +        done < ${SKIPFILE}
>
> This could be written in a simpler form:
>
>         for test_name in $(awk '{print $1}' "$SKIPFILE"); do
>                 case "${test_name}" in \#*) continue;; esac
>                 sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
>         done

I have tested this piece of script and this also works.
Shall i re-send the patch with this modification ?

>
>
> Other than that it looks fine.

- Naresh

>
> --
> Cyril Hrubis
> chrubis@suse.cz