[LTP] [RFC PATCH v2 2/4] lapi/socket.h: Move definitions from netstress.c
Petr Vorel
pvorel@suse.cz
Wed Dec 27 09:42:13 CET 2017
Hi Alexey,
thanks for your review.
> > #ifndef SOCK_CLOEXEC
> > # define SOCK_CLOEXEC 02000000
> > #endif
> > +#ifndef SOCK_DCCP
> > +# define SOCK_DCCP 6
> > +#endif
> I would move it above SOCK_CLOEXEC, so we can keep the order
> of these flags similarly to bits/socket.h.
You probably mean bits/socket_type.h. Sure.
> The other patches in this set look good, thanks!
Just one exception, if you don't mind:
I use lapi/netinet_in.h instead of lapi/in.h. I don't like inconsistency (other headers in
lapi don't use prefix), but using just in.h is confusing, as there is also linux/in.h, as
Cyril pointed out.
Kind regards,
Petr
More information about the ltp
mailing list