[LTP] [PATCH 1/2] test_net.sh: add tst_set_sysctl()

Cyril Hrubis chrubis@suse.cz
Tue Jan 31 13:41:29 CET 2017


Hi!
> >> +# tst_set_sysctl NAME VALUE [safe]
> >> +# It can handle netns case when sysctl not namespaceified.
> >> +tst_set_sysctl()
> >> +{
> >> +	local name="$1"
> >> +	local value="$2"
> >> +	local safe=
> >> +	[ "$3" = "safe" ] && safe="-s" || safe=""
> > Uh, this syntax is confusing, besides isn't safe set to empty string
> > anyway?
> 
> What if we set TST_NO_CLEANUP just before calling cleanup()
> or unset TST_CLEANUP... then we can use ROD, etc. in cleanup?

You lost me here. How is this connected to the code I've commented?

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list