[LTP] [PATCH v2 1/3] commands/keyctl01: Fix potential infinite loop
Guangwen Feng
fenggw-fnst@cn.fujitsu.com
Tue Jul 18 08:31:42 CEST 2017
End the loop once the max key quota is less than zero, in case
some errors happen and result in endless loop.
We expect the test to trigger key quota excess which breaks the
loop but it may not happen, so add a TWARN message for this.
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
---
testcases/commands/keyctl/keyctl01.sh | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/testcases/commands/keyctl/keyctl01.sh b/testcases/commands/keyctl/keyctl01.sh
index 690fbbf..238b117 100644
--- a/testcases/commands/keyctl/keyctl01.sh
+++ b/testcases/commands/keyctl/keyctl01.sh
@@ -61,15 +61,17 @@ cleanup()
do_test()
{
+ local quota_excd=0
local maxkeysz=$((ORIG_KEYSZ + 100))
- while true
+ while [ $maxkeysz -ge 0 ]
do
echo $maxkeysz >$PATH_KEYQUOTA
keyctl request2 user debug:fred negate @t >temp 2>&1
grep -q -E "quota exceeded" temp
if [ $? -eq 0 ]; then
+ quota_excd=1
break
fi
@@ -82,6 +84,10 @@ do_test()
((maxkeysz -= 4))
done
+ if [ $quota_excd -eq 0 ]; then
+ tst_res TWARN "Failed to trigger the quota excess"
+ fi
+
tst_res TPASS "Bug not reproduced"
}
--
2.9.4
More information about the ltp
mailing list