[LTP] [RFC PATCH v6 09/11] network/stress: Fix and cleanup route IPv4 tests

[Alexey Kodanev]

On 06/27/2017 09:04 AM, Petr Vorel wrote:
> Hi Alexey,
>
> thank you for your review, all will be in v7. Just one comment to initialize_if:
>
>> On 06/03/2017 03:00 PM, Petr Vorel wrote:
> ...
>>> -# Initialize the specified interface
>>> -command="ifconfig $ifname down mtu 1500 ; ip route flush dev $ifname ; ip addr flush dev $ifname ; ifconfig $ifname up"
>>> -
>>>  if [ $host_type = lhost ]; then
>>>      ( ifconfig $ifname down && \
>>>      ip link set mtu 1500 dev $ifname && \
>> There are no changes in route IPv6 tests, why do we need this for route
>> IPv4?
> testcases/network/stress/ns-tools/initialize_if is a legacy script. Instead of fixing it
> should it's usage should be replaced by functions from test_net.sh or test_stress_net.sh
> and the file deleted.

Hi Petr,

Right, the usage of 'initialize_if' is replaced in route4 patch, so
the question was why we need this change in 'initialize_if' here?

Thanks,
Alexey