[LTP] [PATCH 1/2] cpuhotplug05.sh: call sar -P $CPU_TO_TEST

Stanislav Kholmanskikh stanislav.kholmanskikh@oracle.com
Thu Jul 20 16:35:29 CEST 2017



On 07/20/2017 04:40 PM, Cyril Hrubis wrote:
> Hi!
>> +	online_status=$(tail -n 1 "$LOG_FILE")
>> +	check_passed=0
>> +	for i in $(seq 3 8); do
>> +		field_offline=$(get_field "$offline_status" "$i")
>> +		field_online=$(get_field "$online_status" "$i")
>> +
>> +		if [ "$field_online" != "$field_offline" ]; then
> 
> Hmm, we did assert that $field_offline == 0.00 in the previous loop,
> didn't we? Why don't we simply compare $field_online against "0.00"
> here?

Indeed. That's my miss. I've updated it to $field_online != "0.00" and
pushed the series.

Thank you.

> 
> Otherwise it looks fine.
> 


More information about the ltp mailing list