[LTP] [PATCH v2 1/2] lib/test.sh: Remove temporary directory only if we know the location

Petr Vorel pvorel@suse.cz
Mon Jul 24 09:00:37 CEST 2017


Hi Cyril,

> Hi!
> > This is a problem when a test TCONF before calling tst_tmpdir, but has
> > tst_rmdir in cleanup function (e.g. dhcp_lib.sh when failing on
> > tst_check_cmds).

> I was wondering if we should produce at least TINFO message that
> something is probably wrong with the cleanup function, but nobody would
> read that unless we used TWARN.
Actually I think it's a good idea to put TWARN. That would indeed help to us to catch
errors in scripts.

> So I guess that the patch is OK as it is, pushed, thanks.
Thanks!


Kind regards,
Petr


More information about the ltp mailing list