[LTP] [PATCH 2/2] color: Fix backslash-escape sequences for some non-bash shells

[Petr Vorel]

Hi Cyril,

> > -#define ANSI_COLOR_RESET	"\e[00m"
> > +#define ANSI_COLOR_RESET	"\033[0m"

> I suppose that we are changing the C header to keep it consistent with
> the shell one? I guess that's OK.
yep. I guess it's better to use the same notation, even the current notation is working in
C header.

> >  	# NOTE: these colors should match colors defined in include/tst_ansi_color.h
> > -	local ansi_color_blue='\e[1;34m'
> > -	local ansi_color_green='\e[1;32m'
> > -	local ansi_color_magenta='\e[1;35m'
> > -	local ansi_color_red='\e[1;31m'
> > -	local ansi_color_yellow='\e[1;33m'
> > +	local ansi_color_blue='\033[34;1m'
> > +	local ansi_color_green='\033[32;1m'
> > +	local ansi_color_magenta='\033[35;1m'
> > +	local ansi_color_red='\033[31;1m'
> > +	local ansi_color_yellow='\033[33;1m'

> I'm a bit puzzled by the change of the position of color and bold in the
> escape sequence. As far as I can tell it does not matter at all, or does
> it?
Sorry, my inattention, I'll generate v2.


> And the patch description does not describe this part of the change
> either...
What part exactly? The one below?

> >  	case "$1" in
> >  	TPASS) printf $ansi_color_green;;
> > @@ -52,5 +52,5 @@ tst_print_colored()

> >  	[ "$color" = "1" ] && tst_flag2color "$1"
> >  	printf "$2"
> > -	[ "$color" = "1" ] && printf '\e[00m'
> > +	[ "$color" = "1" ] && printf '\033[0m'


Kind regards,
Petr