[LTP] [PATCH v2] min_free_kbytes: Check panic_on_oom in advance

Hoang Nguyen the_hoang0709@yahoo.com
Sun Mar 5 05:02:52 CET 2017


Hi Cyril,
Thanks. I'll fix it in new patch.
Best regards,
Hoang

      From: Cyril Hrubis <chrubis@suse.cz>
 To: the_hoang0709@yahoo.com 
Cc: ltp@lists.linux.it
 Sent: Friday, 3 March 2017, 16:45
 Subject: Re: [LTP] [PATCH v2] min_free_kbytes: Check panic_on_oom in advance
   
Hi!
> Signed-off-by: Hoang Nguyen <the_hoang0709@yahoo.com>
> ---
>  testcases/kernel/mem/tunable/min_free_kbytes.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/testcases/kernel/mem/tunable/min_free_kbytes.c b/testcases/kernel/mem/tunable/min_free_kbytes.c
> index cb00f40..1f6fc8f 100644
> --- a/testcases/kernel/mem/tunable/min_free_kbytes.c
> +++ b/testcases/kernel/mem/tunable/min_free_kbytes.c
> @@ -239,6 +239,11 @@ static void sighandler(int signo LTP_ATTRIBUTE_UNUSED)
>  void setup(void)
>  {
>      tst_require_root();
> +    if (get_sys_tune("panic_on_oom")) {
> +        tst_brkm(TCONF, NULL,
> +            "panic_on_oom is set, disable it to run these testcases");
> +    }

Now the indentation is wrong, please make sure to use tabs. FYI you can
use checkpatch.pl from kernel git repo to check patches before sending
them for review.

-- 
Cyril Hrubis
chrubis@suse.cz


   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20170305/ffe7e7bf/attachment.html>


More information about the ltp mailing list