[LTP] [RFC] [PATCH] syscalls/move_pages12: Two fixes.

Cyril Hrubis chrubis@suse.cz
Fri May 5 14:55:39 CEST 2017


Hi!
> > * Do not multiply free ram with 1024
> > 
> >   - Since we get overflow even on fairly modest
> >     machine with a few GB of RAM and the test
> >     will always report "Not enough RAM".
> 
> This is obviously ok.

I've pushed this part.

> > 
> > * Drop caches before the test
> > 
> >   - Otherwise the move_pages() syscalls may
> >     fail with ENOMEM.
> > 
> 
> How about we try to allocate/touch couple MB worth of pages
> on node, we are going to move to (alloc_pages_on_node())?
> If we can't allocate, exit with TCONF.
> 
> Otherwise we free those pages just before move_pages().
> Wouldn't that give us better guarantee, there are some
> free pages on target node?

Sounds reasonable, I will look into this.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list