[LTP] [PATCH 1/3] lib: setup rhost TST_TMPDIR if net test sets TST_NEEDS_TMPDIR

Alexey Kodanev alexey.kodanev@oracle.com
Wed Nov 1 13:32:34 CET 2017


On 10/31/2017 01:23 PM, Petr Vorel wrote:
>> tst_tmpdir() in test_net.sh should be removed when network tests
>> converted to newer lib.
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
>> ---
>>  testcases/lib/test.sh     |    2 ++
>>  testcases/lib/test_net.sh |   12 ++++++++++++
>>  testcases/lib/tst_test.sh |    2 ++
>>  3 files changed, 16 insertions(+), 0 deletions(-)
> LGTM.
>
> <snip>
>> +if [ "$TST_NEEDS_TMPDIR" = 1 ]; then
> I prefer "1", but that's only a detail:

Yes, quite optional here, I followed the style that is used in
test.sh/tst_test.sh already.

Applied.

Thanks,
Alexey



More information about the ltp mailing list