[LTP] [RFC PATCH 3/4] lapi: Add lapi/in.h with definition moved from netstress.c

Petr Vorel pvorel@suse.cz
Tue Nov 21 12:51:35 CET 2017


Hi,

> > Maybe we should rename this file to netinet_in.h or create netinet
> > directory in lapi. Including just lapi/in.h is a bit confusing.
> Is it because in.h is also in bits/ directory (not only in linux and some glibc directory)?
> /usr/include/bits/in.h
> /usr/include/netinet/in.h
> /usr/include/linux/in.h

> As the same we have with lapi/tcp.h (in both kernel and glibc)...
> /usr/include/netinet/tcp.h
> /usr/include/linux/tcp.h

> And I'm for directory.
Actually I'd be for just plain "in.h" as other fileas in lapi/ directory don't prefix
anything, aren't in any special directory.
But if you really don't like that, I'll put it into netinet_in.h.


Kind regards,
Petr


More information about the ltp mailing list