[LTP] [PATCH 4/6] lib: extend PATH as part of test setup

Jan Stancek jstancek@redhat.com
Wed Oct 11 09:45:59 CEST 2017




----- Original Message -----
> I do not like the strcat() function much, I would have probably handled
> these with asprintf();
> 
> 	if (old_path)
> 		SAFE_ASPRINTF(&new_path, "%s::%s", old_path, start_dir);
> 	else
> 		SAFE_ASPRINTF(&new_path, "::%s", start_dir);

This makes it simpler, I've modified it to use SAFE_ASPRINTF.

> 
> 
> The rest of the patchset looks good.

I pushed all with your ACK.

> 
> BTW, we should also drop the note about setting $PATH from the
> documentation once this is merged.

Or tweak it to say, it's no longer necessary for newlib tests.

Regards,
Jan


More information about the ltp mailing list