[LTP] [PATCH v2 04/15] lib/tst_test: Add .all_filesystems flag

Jan Stancek jstancek@redhat.com
Wed Oct 11 13:17:11 CEST 2017



----- Original Message -----
> Hi!
> > > > 3) fs_fill test is still quite verbose
> > > > 
> > > > # ./fs_fill > log2 2>&1
> > > > # du -h log2
> > > > 688K	log2
> > > > 
> > > > # grep Got log2
> > > > fs_fill.c:96: PASS: Got 5713 ENOSPC
> > > > fs_fill.c:96: PASS: Got 9 ENOSPC
> > > > fs_fill.c:96: PASS: Got 1709 ENOSPC
> > > > 
> > > > I'm running this on single CPU KVM guest, which is (presumably due to
> > > > caching
> > > > and host SSD) able to trigger ENOSPC many times in those 2 seconds.
> > > > 
> > > > I expect baremetal systems with many CPUs producing lot of output as
> > > > well,
> > > > because we start tst_fill_fs() in NR_CPU+2 threads.
> > > 
> > > Okay. What about rewriting the main loop to sleep in short intervals and
> > > check the ENOSCP counter and exit if reasonably large number was found.
> > 
> > There might be systems, where I/O is very slow and waiting for 100
> > ENOSPC might take too long. So, I think it should be both enospc_cnt
> > and total time as well. Whatever comes first, we exit. That should
> > limit max test output to ~10kB.
> 
> Sure so what about exitting either at 100 ENOSPC or after 1s in a case
> that we got at least one ENOSPC?

Sounds good to me.

Regards,
Jan


More information about the ltp mailing list