[LTP] [PATCH] ltp: keep the .tid hidden in the test library

Li Wang liwang@redhat.com
Wed Oct 25 11:15:04 CEST 2017


On Wed, Oct 25, 2017 at 5:05 PM, Cyril Hrubis <chrubis@suse.cz> wrote:
> Hi!
>> Attaching a new patch to achieve the same target in another way. It
>> just remove the .tid from test struct and take use of TCID to replace.
>>
>> Which one do you think is better?
>
> I think that removing it from the test structure is better, but reusing
> the oldlib TCID seems to be a bit messy solution to me. We may get rid
> of that one in the future, if we happen to convert all the oldlib
> testcases. I would be a bit happier if we decleared static char *tid in
> the tst_test.c instead.

Ok, I understand. Thanks for reviewing quickly. Let me drafted a new patch.


More information about the ltp mailing list