[LTP] [PATCH v5 07/12] hotplug/memory_hotplug: Remove unused header

Cyril Hrubis chrubis@suse.cz
Thu Oct 26 12:53:44 CEST 2017


Hi!
>  #include "config.h"
> -#if HAVE_NUMA_H && HAVE_LINUX_MEMPOLICY_H && HAVE_NUMAIF_H
> -#include <linux/mempolicy.h>
> +#if HAVE_NUMA_H && HAVE_NUMAIF_H

I guess that we have the same definitions in the linux/mempolicy.h and
numaif.h, right? I wonder how we even could include both of them without
producing warnings for constant redefinitions, etc.

Anyway, can you please include a bit more explanation in the commit
message? Something along the lines that the constant are present in both
headers and that we only need to include one?

Otherwise it looks good to me.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list