[LTP] [PATCH 07/18] vma03: accept ENOMEM return value from mremap

Cyril Hrubis chrubis@suse.cz
Tue Oct 31 12:11:44 CET 2017


Hi!
> Attempting to map a wrapping region with mremap should fail (that's the
> whole point of this test). Accept ENOMEM as well as EINVAL.

I'm missing any background info here about the specific conditions where
this happens. The test is supposed to run only on 32bit kernel, so I
suppose that there is some older board with 32bit ARM that is able to
execute this test and that we get a different errno there, but that is
only speculation. Can you, pretty please, elaborate more on that?

> Signed-off-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> ---
>  testcases/kernel/mem/vma/vma03.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/mem/vma/vma03.c b/testcases/kernel/mem/vma/vma03.c
> index 4b34ab0a0..5f231e5bb 100644
> --- a/testcases/kernel/mem/vma/vma03.c
> +++ b/testcases/kernel/mem/vma/vma03.c
> @@ -100,7 +100,7 @@ int main(int argc, char *argv[])
>  
>  		remap = mremap(map, pgsz, 2 * pgsz, 0);
>  		if (remap == MAP_FAILED) {
> -			if (errno == EINVAL)
> +			if (errno == EINVAL || errno == ENOMEM)
>  				tst_resm(TPASS, "mremap failed as expected.");
>  			else
>  				tst_resm(TFAIL | TERRNO, "mremap");
> -- 
> 2.14.2
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list