[LTP] [PATCH 01/18] Move check_hugepage() helper to mem/lib

Punit Agrawal punit.agrawal@arm.com
Tue Oct 31 13:45:34 CET 2017


Hi Cyril,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> diff --git a/testcases/kernel/mem/hugetlb/lib/hugetlb.h b/testcases/kernel/mem/hugetlb/lib/hugetlb.h
>> index c6d2016b7..f4a1a75d7 100644
>> --- a/testcases/kernel/mem/hugetlb/lib/hugetlb.h
>> +++ b/testcases/kernel/mem/hugetlb/lib/hugetlb.h
>> @@ -45,7 +45,6 @@
>>   * from shmid_ds.ipc_perm.mode
>>   */
>>  #define MODE_MASK	0x01FF
>> -#define PATH_HUGEPAGES	"/sys/kernel/mm/hugepages/"
>>  
>>  key_t shmkey;			/* an IPC key generated by ftok() */
>
> We should remove the check_hugepage() prototype from this header as
> well, otherwise it's fine.

Fixed locally.

Thanks for reviewing the patches (hopefully you can reach the end of the
series :) ). Some of your suggestions are straight forward but others
will take some time.

I am about to disappear for a few days and will aim to act on your
suggestions once I'm back.

Thanks,
Punit


More information about the ltp mailing list