[LTP] [PATCH 3/3] cve/cve-2016-7042: Make use of the fallback functions in lapi/keyctl.h
Guangwen Feng
fenggw-fnst@cn.fujitsu.com
Wed Sep 6 11:56:23 CEST 2017
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
---
testcases/cve/Makefile | 1 +
testcases/cve/cve-2016-7042.c | 12 ++++--------
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/testcases/cve/Makefile b/testcases/cve/Makefile
index 04abc1f..db87299 100644
--- a/testcases/cve/Makefile
+++ b/testcases/cve/Makefile
@@ -17,6 +17,7 @@ top_srcdir ?= ../..
include $(top_srcdir)/include/mk/testcases.mk
+LDLIBS += $(KEYUTILS_LIBS)
CFLAGS += -D_GNU_SOURCE
cve-2016-7117: CFLAGS += -pthread
diff --git a/testcases/cve/cve-2016-7042.c b/testcases/cve/cve-2016-7042.c
index ff9c057..8719eba 100644
--- a/testcases/cve/cve-2016-7042.c
+++ b/testcases/cve/cve-2016-7042.c
@@ -31,7 +31,6 @@
#include <stdio.h>
#include "tst_test.h"
-#include "lapi/syscalls.h"
#include "lapi/keyctl.h"
#define PATH_KEYS "/proc/keys"
@@ -43,12 +42,11 @@ static void do_test(void)
{
char buf[BUFSIZ];
- key = tst_syscall(__NR_add_key,
- "user", "ltptestkey", "a", 1, KEY_SPEC_SESSION_KEYRING);
+ key = add_key("user", "ltptestkey", "a", 1, KEY_SPEC_SESSION_KEYRING);
if (key == -1)
tst_brk(TBROK, "Failed to add key");
- if (tst_syscall(__NR_keyctl, KEYCTL_UPDATE, key, "b", 1))
+ if (keyctl(KEYCTL_UPDATE, key, "b", 1))
tst_brk(TBROK, "Failed to update key");
fd = SAFE_OPEN(PATH_KEYS, O_RDONLY);
@@ -61,8 +59,7 @@ static void do_test(void)
SAFE_CLOSE(fd);
- if (tst_syscall(__NR_keyctl, KEYCTL_UNLINK, key,
- KEY_SPEC_SESSION_KEYRING))
+ if (keyctl(KEYCTL_UNLINK, key, KEY_SPEC_SESSION_KEYRING))
tst_brk(TBROK, "Failed to unlink key");
key = 0;
}
@@ -75,8 +72,7 @@ static void setup(void)
static void cleanup(void)
{
- if (key > 0 && tst_syscall(__NR_keyctl, KEYCTL_UNLINK, key,
- KEY_SPEC_SESSION_KEYRING))
+ if (key > 0 && keyctl(KEYCTL_UNLINK, key, KEY_SPEC_SESSION_KEYRING))
tst_res(TWARN, "Failed to unlink key");
if (fd > 0)
--
2.9.4
More information about the ltp
mailing list