[LTP] [PATCH 1/2] mem: ksm: fix volatile page false positive

Richard Palethorpe rpalethorpe@suse.de
Tue Sep 12 10:11:32 CEST 2017


Hello,

Andrea Arcangeli writes:

> +	/*
> +	 * The current scan is already in progress so we wouldn't
> +	 * guarantee to call get_user_pages() on every existing
> +	 * rmap_item if we only waited the remaining part of the
> +	 * current scan.

Only a minor nit, but the wording is a bit unnatural here, it should
probably be: "... in progress so we can't guarantee that
get_user_pages() is is called on every existing rmap_item if ..."

> +	 *
> +	 * The actual merging happens after the unstable tree has been
> +	 * built so we need to wait at least two full scans to
> +	 * guarantee merging, so wait full_scans to increment by 3 so
> +	 * at least two full scans will run.
> +	 */

--
Thank you,
Richard.


More information about the ltp mailing list