[LTP] [PATCH] syscalls/shmat01: avoid dumping corefile for expected crash

[Jan Stancek]

----- Original Message -----
> Hi!
> > > 1 is a special case, that disables also coredump-into-pipe,
> > > and it also happens to be small enough to skip coredump-to-file.
> > > 
> > > fs/coredump.c:
> > >   "if (cprm.limit == 1) {"
> > > 
> > > > The manual says that when we set it to 0 no core file are created. I
> > > > find that better than setting it to 1 which supposedly creates 1 byte
> > > > file...
> > > 
> > > That shouldn't happen because of this check:
> > >   if (cprm.limit < binfmt->min_coredump)
> > 
> > I guess that we should get the setrlimit manual page update then.
> > 
> > Looking at the kernel code it will skip the core-file creation silently
> > unless the minimal size > PAGE_SIZE for most of the binfmt handlers.
> 
> Also consider the patch acked, but please add a bit more descriptive
> commit message, i.e. why the limit is set to 1 and not 0.

Pushed with extra comment.

Regards,
Jan