[LTP] [RESEND][PATCH v3 2/2] syscalls/access04: use .needs_rofs flag for EROFS testing

[Sandeep Patil]

On Tue, Sep 19, 2017 at 10:47:29AM +0200, Cyril Hrubis wrote:
> Hi!
> > Prefer to use the read-only bind mount of '/' over create,
> > format and mount a filesystem image for testing 'EROFS' return
> > value from access()
> > 
> > Signed-off-by: Sandeep Patil <sspatil@google.com>
> > ---
> >  testcases/kernel/syscalls/access/access04.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/testcases/kernel/syscalls/access/access04.c b/testcases/kernel/syscalls/access/access04.c
> > index dbb6d271a..626e6df2c 100644
> > --- a/testcases/kernel/syscalls/access/access04.c
> > +++ b/testcases/kernel/syscalls/access/access04.c
> > @@ -125,9 +125,8 @@ static struct tst_test test = {
> >  	.needs_tmpdir = 1,
> >  	.needs_root = 1,
> >  	.forks_child = 1,
> > -	.mount_device = 1,
> > +	.needs_rofs = 1,
> >  	.mntpoint = MNT_POINT,
> > -	.mnt_flags = MS_RDONLY,
> >  	.setup = setup,
> >  	.test = verify_access,
> >  };
> 
> This is obviously correct, how many testcases can use this interface?

I had this in the cover letter, but here's the preliminary list of tests
that will end up using .need_rofs.

  access04, mkdirat02, mknodat02, acct01, fchown04, mknod07 etc.

- ssp

> 
> Lookint into the git tree, there is at least creat06 that could be
> converted in the very same way, then there is a quite a bit of testcases
> that will need to be converted to the new test library first.

Ack, I have a list of tests to be converted to new library too. Some of them
also will make those tests run in Android environment, so I shall follow up
with the conversion patches post release too.

- ssp

> 
> -- 
> Cyril Hrubis
> chrubis@suse.cz