[LTP] [PATCH 2/2] commands/file: Compile in.c with -no-pie
Cyril Hrubis
chrubis@suse.cz
Tue Sep 26 11:37:31 CEST 2017
Hi!
> On newer gcc, --enable-default-pie is enabled by default,
> thus in.c is compiled as position independent executable
> file, which leads to test failure unexpectedly.
>
> Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
> Signed-off-by: Fei Jie <feij.fnst@cn.fujitsu.com>
> ---
> testcases/commands/file/datafiles/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/commands/file/datafiles/Makefile b/testcases/commands/file/datafiles/Makefile
> index d3cb847..b26ce5b 100644
> --- a/testcases/commands/file/datafiles/Makefile
> +++ b/testcases/commands/file/datafiles/Makefile
> @@ -14,6 +14,7 @@
> top_srcdir ?= ../../../..
>
> include $(top_srcdir)/include/mk/env_pre.mk
> +CFLAGS += $(NOPIEFLAGS)
> INSTALL_DIR := testcases/data/file01
> INSTALL_TARGETS := in*
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
Isn't adding an alternative expected string easier than this?
We do have, for instance, four alternative expected outputs for shell
scripts.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list