[LTP] [PATCH] Make floating point tests Android-compatible

Erick Reyes erickreyes@google.com
Tue Apr 3 03:41:51 CEST 2018


Hi Cyril,

Thanks for the feedback. I went with your suggestion and submitted a new
patch. Hopefully I did it right this time.

Thanks!
Erick

On Tue, Mar 27, 2018 at 7:08 AM, Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > Android does not implement pthread_cancel. The function is replaced
> > by a no-op in a compatibility header. In most cases, the only side
> > effect is that threads cannot be interrupted and have to exit normally.
> > However, floating point tests are calling pthread_cancel and waiting for
> > a thread doing pthread_sigwait to be finished (Which will never happen).
> >
> > This patch implements the same logic using pthread_kill with SIGUSR2
> > instead, allowing the tests to run under Android.
>
> First of all the patch is mangled, probaly by your email client, check
> its settings for attachements.
>
> Secondly, looking at the patch, do we really have to join the signal
> handler thread at the end? Cannot we just delete the the
> pthreat_cancel() and pthread_join() for the sig_hand and be done with
> it?
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180402/1d7055d4/attachment.html>


More information about the ltp mailing list