[LTP] [RFC PATCH 1/8] lib/tst_test.c: mntpoint implies tmpdir

[Xiao Yang]

On 2018/04/05 22:01, Cyril Hrubis wrote:
> If mntpoint is set in the test structure we create a directory hence it
> should set needs_tmpdir flag so that we are sure we create directory in
> the right place.
>
> Signed-off-by: Cyril Hrubis<chrubis@suse.cz>
> ---
>   lib/tst_test.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 8be13327c..5e10460b0 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -743,6 +743,9 @@ static void do_setup(int argc, char *argv[])
>   	if (tst_test->all_filesystems)
>   		tst_test->needs_device = 1;
>
> +	if (tst_test->mntpoint)
> +		tst_test->needs_tmpdir = 1;
> +
Hi Cyril,

Setting mntpoint made needs_device flag true, and subsequent 
needs_tmpdir() returned true
and still created a directory which is used to be mounted.  So it seems 
unnecessary to set
needs_tmpdir flag.

Thanks,
Xiao Yang
>   	setup_ipc();
>
>   	if (needs_tmpdir()&&  !tst_tmpdir_created())