[LTP] [RFC PATCH v6 3/7] network.sh: Migrate to new shell API

[Alexey Kodanev]

On 10.04.2018 20:00, Petr Vorel wrote:
> Hi Alexey,
> 
>>> --- a/testscripts/network.sh
>>> +++ b/testscripts/network.sh
>>> @@ -89,7 +89,7 @@ shift $(($OPTIND - 1))
>>>  TST_TOTAL=1
>>>  TCID="network_settings"
>> Do we need these variables in the new API?
> 
> Yes, good catch, both are redundant.
> 
> TCID is invalid, it was required, but with the fix you pointed out (see below) TCID is
> redundant.
> 
> TST_ID:
>  TST_ID="network_settings" would keep previous name:
> network_settings 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface
> 
> without TST_ID is the name of the script (set by tst_test.sh: filename=$(basename $0) ):
> network 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface
> 
> Unless you have any preference I'd user the later (removing TST_ID)
> + removing TST_TOTAL.


There is one more occurrence of TCID in tst_net_stress.sh, is it needed?


Thanks,
Alexey