[LTP] [PATCH 1/2] lib/test_net.sh: lower default test parameters

Alexey Kodanev alexey.kodanev@oracle.com
Thu Apr 12 14:22:43 CEST 2018


On 05.04.2018 16:40, Petr Vorel wrote:
> Hi Alexey,
> 
>> Default scenario should not take hours to complete.
> Great, agree.
> 
>> Also export TST_NETLOAD_CLN_REQUESTS which is used by all
>> tst_netload tests and can control the test execution time.
> 
...
>> +export TST_NETLOAD_CLN_REQUESTS="${TST_NETLOAD_CLN_REQUESTS:-10000}"
> This variable is also in testcases/network/sockets/bind_noport01.sh, shouldn't you remove
> it from there (it uses test_net.sh).
> 
> Also, why not to handle the same way TST_NETLOAD_CLN_NUMBER ?
> (also used in tst_netload).
> 
> And I'd put it into separate commit.

Applied, the changes with TST_NETLOAD_CLN* are in the separate commit.

Thanks,
Alexey


More information about the ltp mailing list