[LTP] [PATCH v3 2/2] network/in6_02: Rewrite to the new library
Petr Vorel
pvorel@suse.cz
Mon Apr 23 16:19:54 CEST 2018
Hi Alexey,
> > - tst_resm(TPASS, "if_indextoname() tests succeed");
> > + tst_res(TPASS, "if_indextoname() test succeed");
> ^
> succeeded?
> > }...
> > - for (i = 0; pini[i].if_index; ++i) {
> > + for (i = 0; pini[i].if_index; i++) {
> ...
> > + /*
> > + * we need to leak at least a page to detect a leak; 1 byte per call
> > * will be detected with getpagesize() calls.
> > */
> > freenicount = getpagesize();
> > - for (i = 0; i < freenicount; ++i) {
> > + for (i = 0; i < freenicount; i++) {
> Hmm, looks like you are intentionally changing '++i' with 'i++' for
> the all 'for' loops in this patch, any good reason to do that?
> Other than that, the patch looks good.
Pushed both patches with changes you requested and your Ack-by.
Thanks a lot for a review.
Kind regards,
Petr
More information about the ltp
mailing list