[LTP] [PATCH 3/3] crypto/crypto_user01.c: new test for information leak bug
Petr Vorel
pvorel@suse.cz
Tue Dec 11 11:55:01 CET 2018
Hi Eric, Richard,
...
> > > Correct, it suffers from bug:
> > > https://www.spinics.net/lists/netdev/msg171764.html
> > > How about adding include <linux/rtnetlink.h> into
> > > include/tst_netlink.h?
> > I think we would also have to include sys/socket.h in tst_netlink.h to
> > really solve the problem.
> > I am not sure if that is a good idea.
> tst_netlink.h already has an implicit dependency on safe_net_fn.h which already
> includes <sys/socket.h>. So it appears the real issue is including
> <linux/rtnetlink.h> (which includes <linux/netlink.h>) before tst_test.h.
> But various other <linux/*> headers include <linux/netlink.h> too, and I don't
> think all should be included in tst_netlink.h, so I guess I'll just move the
> include within the test .c file itself...
If it's the only change, we can do it before merge (no need to repost whole
patchset).
> BTW, I have no system to reproduce this problem on, so you'll just have to tell
> me whether it works. I tried CentOS 6, but this is already fixed there.
Sure, we'll test it (I can reproduce it as well).
> - Eric
Petr
More information about the ltp
mailing list