[LTP] [PATCH v5] syscalls/readahead02: test readahead using posix_fadvise()

Cyril Hrubis chrubis@suse.cz
Tue Dec 18 14:01:07 CET 2018


Hi!
Sorry for the delay.

...

> -	if (ret == EINVAL &&
> -	    (!tc->use_overlay || !readahead_supported)) {
> -		readahead_supported = 0;
> -		tst_res(TCONF, "readahead not supported on %s",
> -			tst_device->fs_type);
> -		return;
> +	if (ret == EINVAL) {
> +		if (tc->use_fadvise &&
> +		    (!tc->use_overlay || !fadvise_supported)) {
> +			fadvise_supported = 0;
> +			tst_res(TCONF, "CONFIG_ADVISE_SYSCALLS not configured "
> +				"in kernel?");
> +			return;
> +		} else if (!tc->use_overlay || !readahead_supported) {

I got rid of the else block here, since we do return at the end of the
if block before it anyways and pushed, thanks.

> +			readahead_supported = 0;
> +			tst_res(TCONF, "readahead not supported on %s",
> +				tst_device->fs_type);
> +			return;
> +		}
>  	}

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list