[LTP] [PATCH] syscalls/mmap17.c: Add new regression test

Jan Stancek jstancek@redhat.com
Tue Feb 6 20:53:14 CET 2018



----- Original Message -----
> > The patch you referenced is x86 specific, so we can restrict the test to
> > x86.
> > Also please set the minimum kernel version this is expected to fail on.
> 1) Before commit c64b04f, we couldn't read phys_addr_bits from
> /proc/cpuinfo in 32-bit kernel on x86.
> 2) On non-x86 architectures, we couldn't read phys_addr_bits from
> /proc/cpuinfo as well.
> 
> According to above reasons, i perfer to check phys_addr_bits in
> /proc/cpuinfo rather than the minimum
> kernel version and x86 architecture.   We can skip this test if
> phys_addr_bits isn't available.

I was referring to kernel patch. Does it make sense for this test
to run on older kernels? Based on description it might crash, so
presumably yes.

But do we also want to report FAIL on older kernels if mmap succeeds?
That does not violate any docs.

> addr[0] = 'a';
If mmap works, this has potential of triggering signal,
which will lead to TBROK.

Regards,
Jan


More information about the ltp mailing list