[LTP] [PATCH] Add regression test for CVE-2017-17053
Michael Moese
mmoese@suse.de
Fri Feb 9 16:44:10 CET 2018
Hi,
On Fri, Feb 09, 2018 at 04:30:01PM +0100, Cyril Hrubis wrote:
> Why do we use the sa.sa_sigaction here instead of sa_handler if we are
> not using the siginfo_t anyways? And why don't we just use
I can change that, of course
> SAFE_SIGNAL(SIGSEGV, handler) as well?
I thought about it, but that would use signal(). Using signal should in
general be avoided in a multithreaded programm (see man signal).
> > + SAFE_MUNMAP((void *) do_exit, sizeof(*do_exit));
> ^
> There is absolutely no reason to cast pointers to
> (void *) in C the conversion is automatic in this
> case.
Eh yes, but I have no idea why I put that cast there in the first
place. Will remove this for v2.
Thanks,
Michael
--
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
More information about the ltp
mailing list