[LTP] [PATCH] open08: calling tst_get_bad_addr from LTP API

[Li Wang]

Maybe we misled by the code comments before, after thinking over, I
guess the "outside your accessible address space" != "outside of
process mapped space". So we don't need to do map/unmap to satisfy
that.

And, the comments should be more precise if change as:

--- a/testcases/kernel/syscalls/open/open08.c
+++ b/testcases/kernel/syscalls/open/open08.c
@@ -44,8 +44,8 @@
  *        open(2) should fail with EACCES.
  *
  *     6. Attempt to pass an invalid pathname with an address pointing outside
- *        the address space of the process, as the argument to open(), and
- *        expect to get EFAULT.
+ *        the accessible address space of the process, as the
argument to open(),
+ *        and expect to get EFAULT.
  */


On Wed, Jul 11, 2018 at 1:16 PM, Li Wang <liwang@redhat.com> wrote:
> From open(2) manual, pathname(unmapped_fname) points outside the
> accessible address space, then test will result in failure with EFAULT.
>
> LTP tst_get_bad_addr() maps a "guard-page" by using PROT_NONE
> to provides page not be accessed too. Here we can take use of
> it to achieve the same purpose.
>
> Signed-off-by: Li Wang <liwang@redhat.com>
> ---
>
> Notes:
>     Jan,
>
>     I'm sorry I didn't think of that function in LTP API when
>     reveiwed your open08 patch.
>
>     Here I propose to remove the get_invalid_addr() from open08.c.
>
>     Li Wang
>
>  testcases/kernel/syscalls/open/open08.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/open/open08.c b/testcases/kernel/syscalls/open/open08.c
> index 5b24752..c407332 100644
> --- a/testcases/kernel/syscalls/open/open08.c
> +++ b/testcases/kernel/syscalls/open/open08.c
> @@ -58,6 +58,7 @@
>  #include <signal.h>
>  #include <pwd.h>
>  #include "tst_test.h"
> +#include "tst_get_bad_addr.h"
>
>  static char *existing_fname = "open08_testfile";
>  static char *toolong_fname = "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstmnopqrstuvwxyzabcdefghijklmnopqrstmnopqrstuvwxyzabcdefghijklmnopqrstmnopqrstuvwxyzabcdefghijklmnopqrstmnopqrstuvwxyzabcdefghijklmnopqrstmnopqrstuvwxyzabcdefghijklmnopqrstmnopqrstuvwxyz";
> @@ -101,17 +102,6 @@ void verify_open(unsigned int i)
>         }
>  }
>
> -static void *get_invalid_addr(void)
> -{
> -       char *bad_addr;
> -       int len = 2 * 1024 * 1024;
> -
> -       bad_addr = SAFE_MMAP(0, len, PROT_READ|PROT_WRITE,
> -               MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
> -       SAFE_MUNMAP(bad_addr, len);
> -       return bad_addr + len/2;
> -}
> -
>  static void setup(void)
>  {
>         int fildes;
> @@ -130,7 +120,7 @@ static void setup(void)
>         fildes = SAFE_CREAT(existing_fname, 0600);
>         close(fildes);
>
> -       unmapped_fname = get_invalid_addr();
> +       unmapped_fname = tst_get_bad_addr(NULL);
>  }
>
>  static struct tst_test test = {
> --
> 2.9.5
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp



-- 
Regards,
Li Wang