[LTP] [PATCH 0/7] TST_IPVER

Petr Vorel pvorel@suse.cz
Wed Jun 6 17:27:29 CEST 2018


Hi Alexey,

> > Petr Vorel (7):
> >   tst_net.sh: Simplify ipver settings code
> >   tst_net.sh: Rename ipver to TST_IPVER
> >   net/dns: Replace $ipver by $TST_IPVER from tst_net.sh
> >   net/ftp: Replace $ipver by $TST_IPVER from tst_net.sh
> >   net/http: Replace $ipver by $TST_IPVER from tst_net.sh
> >   net/ssh: Replace $ipver by $TST_IPVER from tst_net.sh
> >   net/virt: Replace $ipver by $TST_IPVER from tst_net.sh


> The patch-set look good, acked.
Thanks for your review.

> BTW, I would rather split such patches on these logical changes:
> * introduce new TST_IPVER library variable
> * remove $ipver setups and replace the usage with $TST_IPVER.

Sure, much better, than 7 commits.
Changed to your suggestion and pushed with your ack.


Kind regards,
Petr


More information about the ltp mailing list