[LTP] [PATCH] macsec: fix double delete the tmp file

[Sun Lianwen]

Hi Petr

On 06/09/2018 11:06 PM, Petr Vorel wrote:
> Hi Sun,
> 
>> The virt_cleanup and tst_ipsec_cleanup in both in the cleanup() which will 
>> double delete the tmp file. and result to report below info:
>> "rm: cannot remove ‘/tmp/ltp-ddLUcf8ACl/macsec01.6YQ9qGRNuC’: No such file 
>> or directory"
> Thanks for your patch. I've noticed that, but didn't try to fix that as macsec
> tests run under new API doesn't complain, because tst_test.sh (unlike test.sh)
> actually check whether directory exist. (Next week hopefully I'm going to send
> patch which rewrites tests which uses ipsec_lib.sh and virt_lib.sh).
> 
> Your test introduces duplicity with tst_ipsec_cleanup, it's here 3 times
> + code in macsec02.sh uses spaces instead of tabs.
> 
> As the issue isn't specific and it's going to be fixed just by migrating to new
> API, I'd propose not to accept it. Alexey, what do you think?
> 
Thanks your answer, I think you are right. It is nice if the new API can fix this.
> 
> Kind regards,
> Petr
> 
> 
> .
>