[LTP] [PATCH] testcases: cve-2014-0196: Set attempts according to nb of cpus
Jan Stancek
jstancek@redhat.com
Tue Jun 19 13:29:32 CEST 2018
----- Original Message -----
> Hello,
>
> Mylène Josserand writes:
>
> > This test tries to cause a buffer overflow by doing 0x7000
> > attempts. In a slow system platform, it leads to a failure
> > because of the timeout even when it is configured with
> > LTP_TIMEOUT_MUL=10.
> >
> > This commit adds a way to configure the number of attempts
> > according to the number of CPUs.
> > In case of 1 CPU and a slow platform, using 0x2000 attempts
> > with a LTP_TIMEOUT_MUL=2 make the test pass.
> >
> > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> > ---
> >
> > Hello,
> >
> > This is a way to fix the issue I got but let me know
> > what you think of it. There is maybe a better way to
> > handle that.
>
> Another way would be to measure the time a few iterations take and limit
> the number of attempts based on that.
Or measure total time and break the loop early if we come close to TESTTIME:
#define THRESHOLD 5000
tst_timer_start(CLOCK_MONOTONIC);
while (i < attempts) {
tst_timer_stop();
elapsed_ms = tst_timer_elapsed_ms();
if (elapsed_ms + THRESHOLD > TESTTIME)
break;
}
Regards,
Jan
> We should perhaps add that as a
> feature to the fuzzy sync library.
> >
> > Thank you,
> > Mylène
> >
More information about the ltp
mailing list