[LTP] [PATCH 1/3] lib/tst_net.sh: Append 6 to the end of $TST_OPTS

Petr Vorel pvorel@suse.cz
Mon May 7 08:43:43 CEST 2018


Hi,

> If the first character of optstring is set to a colon(tcp_fastopen_run.sh,
> nfs_lib.sh), getopts should be in silent mode rather than process it as
> an argument of 6.

> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  testcases/lib/tst_net.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/lib/tst_net.sh b/testcases/lib/tst_net.sh
> index 3a0fe01..32b4f09 100644
> --- a/testcases/lib/tst_net.sh
> +++ b/testcases/lib/tst_net.sh
> @@ -19,7 +19,7 @@
>  # Author: Alexey Kodanev <alexey.kodanev@oracle.com>


> -TST_OPTS="6$TST_OPTS"
> +TST_OPTS="${TST_OPTS}6"
>  TST_PARSE_ARGS_CALLER="$TST_PARSE_ARGS"
>  TST_PARSE_ARGS="tst_net_parse_args"
>  TST_USAGE_CALLER="$TST_USAGE"

Acked-by: Petr Vorel <pvorel@suse.cz>

Good catch. Although I propose to get rid of ':' at the beginning for users of new shell
API (as it's IMHO better to see errors).


Kind regards,
Petr


More information about the ltp mailing list