[LTP] [PATCH 1/3] lib/tst_net.sh: Append 6 to the end of $TST_OPTS

Petr Vorel pvorel@suse.cz
Mon May 7 10:09:00 CEST 2018


Hi Xiao,

> > Good catch. Although I propose to get rid of ':' at the beginning for users of new shell
> > API (as it's IMHO better to see errors).
> Hi Petr,

> If getopts is in silent mode,  the invalid option is  placed  in OPTARG, so
> we can see errors by printing
> the value of OPTARG.  But it is reasonable for me to get rid of ':' at the
> beginning of optstring. :-)
I know, TBROK inform us, so it can stay how it is for legacy API.
I meant it for the new API, where is going to be removed (the TBROK as well) as error is
handled in tst_run in tst_test.sh.

> Thanks,
> Xiao Yang


Kind regards,
Petr Vorel


More information about the ltp mailing list