[LTP] [PATCH] lib/tst_test.sh: Detect quoted parameters correctly

Xiao Yang yangx.jy@cn.fujitsu.com
Wed May 9 12:54:22 CEST 2018

If we assign "$@" containing quoted parameters to TST_ARGS variable and pass
the variable into getopts, only the first number from quoted parameters can be
processed.  "$@" seems to be treated as an array by default, and declaring
TST_ARGS as an array could fix this issue.

You can reproduce the issue by the folliwng url:
[1] https://lists.linux.it/pipermail/ltp/2018-May/008042.html

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
 testcases/lib/tst_test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
index 8d49d34..2c246c2 100644
--- a/testcases/lib/tst_test.sh
+++ b/testcases/lib/tst_test.sh
@@ -265,7 +265,7 @@ tst_run()
-	while getopts "hi:$TST_OPTS" name $TST_ARGS; do
+	while getopts "hi:$TST_OPTS" name "${TST_ARGS[@]}"; do
 		case $name in
 		'h') tst_usage; exit 0;;
@@ -420,7 +420,7 @@ if [ -z "$TST_NO_DEFAULT_RUN" ]; then
-	TST_ARGS="$@"
+	TST_ARGS=("$@")
 	while getopts ":hi:$TST_OPTS" tst_name; do
 		case $tst_name in

More information about the ltp mailing list