[LTP] [RFC PATCH v4 4/4] tst_test.sh: Add TST_TEST_DATA and TST_TEST_DATA_IFS

Petr Vorel pvorel@suse.cz
Fri May 25 14:10:34 CEST 2018


Hi Cyril,

thanks for review, I'll fix bugs.

> > +_tst_run_tests()
> > +{
> > +	local data="$1"
> > +	local i

> Shouldn't we prefix these two variables with _tst_ prefix as well?
IMHO no, as _tst_run_test and _tst_run_tests is private and these variables are local.
I thought we need to change tst_run as it's run by the tests and all variables which are.

> > +_tst_run_test()
> > +{
> > +	local res=$(_tst_resstr)
> > +	local fnc="$1"
> > +	shift

> And here as well, the _tst_ prefix?
Dtto.


Kind regards,
Petr


More information about the ltp mailing list